]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
authPrompt: Keep password entry on reset
authorGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Thu, 13 Feb 2020 21:05:38 +0000 (18:05 -0300)
committerGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Thu, 13 Feb 2020 21:11:16 +0000 (18:11 -0300)
Usually, logging in or unlocking the session is made asynchronously,
and AuthPrompt properly manages which entry is currently visible.
External code don't rely on any specific entry to be set, since it
is AuthPrompt's responsibility to select the correct one to be shown.

However, there's one specific case where AuthPrompt must preserve
the password entry: on reset. The reset code preserved whatever
entry was currently displayed, but after fe69dacaf1, it always
changes to the username entry.

Make sure to show the password entry on reset.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/999

js/gdm/authPrompt.js

index df8767b829f36488353ea83d2e8f053ae1bb1f5f..5515db60d231a82bb89ffda683fb734335d41319 100644 (file)
@@ -452,6 +452,7 @@ var AuthPrompt = GObject.registerClass({
         this.clear();
         this._message.opacity = 0;
         this.setUser(null);
+        this._updateEntry(true);
         this.stopSpinning();
 
         if (oldStatus == AuthPromptStatus.VERIFICATION_FAILED)